Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agat sp statistics #107

Merged
merged 16 commits into from
Oct 26, 2024
Merged

Add agat sp statistics #107

merged 16 commits into from
Oct 26, 2024

Conversation

Leila011
Copy link
Contributor

@Leila011 Leila011 commented Jul 31, 2024

Description

add agat_sp_statistics

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@Leila011
Copy link
Contributor Author

Leila011 commented Jul 31, 2024

How to deal with an argument that can take multiple type?
The argument gs can take either a file either a number, so I gave it type string but I am not sure if that is the best way to handle it.

     - name: --gs
        alternatives: [-f, -g]
        description: |
          This option inform about the genome size in order to compute more statistics. 
          You can give the size in Nucleotide or directly the fasta file.
        type: string

@Leila011 Leila011 marked this pull request as ready for review July 31, 2024 14:34
@Leila011 Leila011 requested a review from rcannood July 31, 2024 14:38
@jakubmajercik
Copy link
Contributor

How to deal with an argument that can take multiple type? The argument gs can take either a file either a number, so I gave it type string but I am not sure if that is the best way to handle it.

     - name: --gs
        alternatives: [-f, -g]
        description: |
          This option inform about the genome size in order to compute more statistics. 
          You can give the size in Nucleotide or directly the fasta file.
        type: string

I would split it into 2 arguments.

src/agat/agat_sp_statistics/config.vsh.yaml Outdated Show resolved Hide resolved
src/agat/agat_sp_statistics/config.vsh.yaml Outdated Show resolved Hide resolved
src/agat/agat_sp_statistics/help.txt Outdated Show resolved Hide resolved
src/agat/agat_sp_statistics/script.sh Outdated Show resolved Hide resolved
@emmarousseau emmarousseau self-requested a review October 26, 2024 10:49
Copy link
Collaborator

@emmarousseau emmarousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced test data size
Add tool name to version format
Minor config formatting changes

Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm!

@rcannood rcannood merged commit d6c9475 into main Oct 26, 2024
2 checks passed
@rcannood rcannood deleted the add-agat_sp_statistics branch October 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants