Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agat sp filter feature from kill list #105

Merged
merged 34 commits into from
Oct 26, 2024

Conversation

Leila011
Copy link
Contributor

@Leila011 Leila011 commented Jul 31, 2024

Description

add agat_sp_filter_feature_from_kill_list
added --verbose command

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@Leila011 Leila011 marked this pull request as ready for review July 31, 2024 11:52
@Leila011 Leila011 requested a review from rcannood July 31, 2024 11:53
@Leila011 Leila011 requested review from DriesSchaumont and removed request for rcannood August 8, 2024 07:10
Copy link
Contributor

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions

@emmarousseau emmarousseau requested review from emmarousseau and removed request for DriesSchaumont October 26, 2024 10:00
Copy link
Collaborator

@emmarousseau emmarousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced test data size
Minor changes to config formatting

@rcannood rcannood merged commit ebbc0d4 into main Oct 26, 2024
1 check passed
@rcannood rcannood deleted the add-agat_sp_filter_feature_from_kill_list branch October 26, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants