Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedtools_bamtofastq #101

Merged
merged 13 commits into from
Aug 13, 2024
Merged

Bedtools_bamtofastq #101

merged 13 commits into from
Aug 13, 2024

Conversation

tgaspe
Copy link
Contributor

@tgaspe tgaspe commented Jul 30, 2024

Description

Creating component bedtools_bamtofastq

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@DriesSchaumont DriesSchaumont self-requested a review August 8, 2024 07:09
@jakubmajercik jakubmajercik self-requested a review August 8, 2024 12:33
output.bam Outdated Show resolved Hide resolved
src/bedtools/bedtools_bamtofastq/config.vsh.yaml Outdated Show resolved Hide resolved
src/bedtools/bedtools_bamtofastq/config.vsh.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment. Don't forget to request another review once you have applied the requested changes (you can do this next by clicking the button next to the name of the reviewer in the revieuwers-section of a PR) :)

src/bedtools/bedtools_bamtofastq/script.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit d7cb75a into viash-hub:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants