Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agat convert genscan2gff #100

Merged
merged 25 commits into from
Sep 16, 2024
Merged

Add agat convert genscan2gff #100

merged 25 commits into from
Sep 16, 2024

Conversation

Leila011
Copy link
Contributor

@Leila011 Leila011 commented Jul 30, 2024

Description

add agat_convert_genscan2gff

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@Leila011 Leila011 requested a review from rcannood July 30, 2024 11:52
@Leila011 Leila011 marked this pull request as ready for review July 31, 2024 09:52
@Leila011
Copy link
Contributor Author

Leila011 commented Aug 6, 2024

agat_convert_genscan2gff source code names but does not use anywhere the argument --inflate_off. Should I open an issue on Agat about it or just remove it from the config file. Or both

Also I am not so sure if --inflate-off should be a boolean_false as i initially specified in the config. I wanted to check its behavior in the source code to understand better but well as explain below I could not.

@rcannood
Copy link
Contributor

agat_convert_genscan2gff source code names but does not use anywhere the argument --inflate_off. Should I open an issue on Agat about it or just remove it from the config file. Or both

Also I am not so sure if --inflate-off should be a boolean_false as i initially specified in the config. I wanted to check its behavior in the source code to understand better but well as explain below I could not.

Feel free to create a issue for this -- their help file explicitly states so !

Whether you include this argument in the component is up to you :)

@Leila011 Leila011 requested review from rcannood August 19, 2024 06:49
@rcannood rcannood merged commit 38f635a into main Sep 16, 2024
2 checks passed
@rcannood rcannood deleted the add-agat_convert_genscan2gff branch September 16, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants