Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pear #10

Merged
merged 17 commits into from
Feb 2, 2024
Merged

Add pear #10

merged 17 commits into from
Feb 2, 2024

Conversation

KaiWaldrant
Copy link
Member

@KaiWaldrant KaiWaldrant commented Jan 29, 2024

Description

Add the PEAR component based on nf-core and snakemake components

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Some minor comments:

src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/config.vsh.yaml Show resolved Hide resolved
src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/script.sh Outdated Show resolved Hide resolved
src/pear/test_data/reads.left.fq.gz Outdated Show resolved Hide resolved
@KaiWaldrant KaiWaldrant requested a review from rcannood January 29, 2024 21:06
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions ^^

src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/script.sh Outdated Show resolved Hide resolved
src/pear/script.sh Outdated Show resolved Hide resolved
@KaiWaldrant KaiWaldrant requested a review from rcannood January 31, 2024 08:44
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted this

src/pear/config.vsh.yaml Outdated Show resolved Hide resolved
src/pear/script.sh Outdated Show resolved Hide resolved
src/pear/test.sh Outdated Show resolved Hide resolved
@rcannood rcannood merged commit f54af0a into main Feb 2, 2024
6 checks passed
@rcannood rcannood deleted the add_pear branch February 2, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants