Skip to content

Commit

Permalink
Fixes the typo raised in issue #132 (#157)
Browse files Browse the repository at this point in the history
* Fixes the typo raised in issue #132

* Add changelog entry

* fix typo, modify script

---------

Co-authored-by: jakubmajercik <[email protected]>
  • Loading branch information
Grifs and jakubmajercik authored Sep 27, 2024
1 parent 63de1c1 commit 237a2e3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@

* `rsem/rsem_calculate_expression`: Calculate expression levels (PR #93).

## BREAKING CHANGES

* `falco`: Fix a typo in the `--reverse_complement` argument (PR #157).

## MINOR CHANGES

* Upgrade to Viash 0.9.0.
Expand Down
2 changes: 1 addition & 1 deletion src/falco/config.vsh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ argument_groups:
bisulfite sequencing, and more Ts and fewer
Cs are therefore expected and will be
accounted for in base content.
- name: --reverse_complliment
- name: --reverse_complement
alternatives: [-r]
type: boolean_true
description: |
Expand Down
4 changes: 2 additions & 2 deletions src/falco/script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -eo pipefail

[[ "$par_nogroup" == "false" ]] && unset par_nogroup
[[ "$par_bisulfite" == "false" ]] && unset par_bisulfite
[[ "$par_reverse_compliment" == "false" ]] && unset par_reverse_compliment
[[ "$par_reverse_complement" == "false" ]] && unset par_reverse_complement

IFS=";" read -ra input <<< $par_input

Expand All @@ -15,7 +15,7 @@ $(which falco) \
${par_limits:+--limits "$par_limits"} \
${par_subsample:+-subsample $par_subsample} \
${par_bisulfite:+-bisulfite} \
${par_reverse_compliment:+-reverse-compliment} \
${par_reverse_complement:+-reverse-complement} \
${par_outdir:+--outdir "$par_outdir"} \
${par_format:+--format "$par_format"} \
${par_data_filename:+-data-filename "$par_data_filename"} \
Expand Down

0 comments on commit 237a2e3

Please sign in to comment.