-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-9260] [RSDK-9252] [APP-6402] [APP-6234] [APP-5296] [APP-6233] [RSDK-7052] Various Small Fixes #41
base: main
Are you sure you want to change the base?
Conversation
…e paths with shell expansion.
@michaellee1019 Review only if you have time, but this should fix several issues you had with preinstall (both the scrdipt and early functionality.) You'd also mentioned earlier today (thursday) you'd seen another issue with a bad PSK causing problems, so wondering if you reproduced that or not. If so, I will probably want to make sure a fix for that gets in here as well. |
Will do more testing this afternoon, currently bug reporting has been mixed with testing for the agent ui updates. Its feeling like the issues im seeing are non deterministic, but probably can narrow it down by changing less config each time to repro the exact situation. Still working on testing this binary, because im using MacOS need to build within canon and still working on setting up a good image to test with. |
Didnt get to more testing today. Will do first thing monday. If you want, merge this so it makes the next release and can do the rest in another PR. |
No description provided.