Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As issue 77 #146

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

As issue 77 #146

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2011

This is a merge of changes
activescaffold@8d60d2b (http://code.google.com/p/activescaffold/issues/detail?id=77) and
activescaffold@9323d75

without the depreciation warnings as requested in private discussion.

@vhochstein
Copy link
Owner

Hi,

just one quick question

  1. what about override_form_field_partial ?

@ghost
Copy link
Author

ghost commented May 19, 2011

Please be more specific. Is there any deficiency?

@vhochstein
Copy link
Owner

Well, old method style is nt possible anymore for override_form_field_partial?
Maybe I am wrong... That s why I raised the question

@ghost
Copy link
Author

ghost commented May 19, 2011

Right, that's what activescaffold/active_scaffold did in the two commits. I can adjust it to enable the old-style if you want:

  def override_form_field_partial(column)
    path = active_scaffold_controller_for(column.active_record_class).controller_path
    partial_name = "#{clean_column_name(column.name)}_form_column"
    if template_exists?(partial_name, path, true)
      File.join(path, partial_name)
    else
      partial_name
    end
  end

@vhochstein
Copy link
Owner

Well, we agreed upon that both styles should be possible...
So, yes I would say we need that change..

… there is no such partial in the directory of the record's own controller. Requested by vhochstein.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants