-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPT: Use regex to get NSIS binaries on Windows #102
base: AddAppveyor
Are you sure you want to change the base?
Conversation
@vgvassilev Please do not merge this now. I am fixing the Appveyor builds, and will rebase to squash the unwanted commits. |
@onyb: ok, could you rebase. I made some progress with it. |
7f70696
to
9165957
Compare
PR #103 is integrated. Could you rebase this on the master? |
@reikdas, could we resurrect this one, I think this code is relevant for packaging quite a lot. |
Sure. |
When we create a package yes. Nsis will create an installable file with the standard click-through approach which some windows users find more native. |
Do we always want NSIS version 3.0? The page the version number is currently being extracted from(https://github.com/vgvassilev/cling/blob/master/tools/packaging/cpt.py#L1210) extracts version 3.0 but the latest NSIS version is version 3.04 (https://sourceforge.net/p/nsis/news/). If not, we should probably extract the version number from this - https://sourceforge.net/projects/nsis/best_release.json (more details here - https://sourceforge.net/p/forge/documentation/Using%20the%20Release%20API/#the-response). |
Is there something we want to use which is not in version 3.0? I don’t mind using any version you prefer, as long as it does the right thing. |
No description provided.