Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paranthesis for derivative of division operator #887

Merged
merged 1 commit into from
May 8, 2024

Conversation

vaithak
Copy link
Collaborator

@vaithak vaithak commented May 8, 2024

fixes #880

Copy link
Contributor

github-actions bot commented May 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev
Copy link
Owner

@vaithak, can you fix the cuda test by adding parenthesis, too?

@vaithak
Copy link
Collaborator Author

vaithak commented May 8, 2024

@vaithak, can you fix the cuda test by adding parenthesis, too?

Yup, will do

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (69a2d0c) to head (3afad84).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #887   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          52       52           
  Lines        7714     7714           
=======================================
  Hits         7311     7311           
  Misses        403      403           
Files Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 97.18% <100.00%> (ø)
Files Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 97.18% <100.00%> (ø)

@vaithak
Copy link
Collaborator Author

vaithak commented May 8, 2024

We can do "squash and merge" on this, when its good to go.
Squashed the commits 👍🏼

Copy link
Contributor

github-actions bot commented May 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented May 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev merged commit 5fa1c55 into vgvassilev:master May 8, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-compilable code output for division operation in reverse mode
2 participants