Fix clang tidy ci #886
Merged
Fix clang tidy ci #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #886 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 52 52
Lines 7703 7703
=======================================
Hits 7304 7304
Misses 399 399
|
|
@vgvassilev To avoid any new merges which don't work just like CppInterOp and xeus-cpp I have made a change to the code to test that the review workflow now works. I just removed a line so it activates. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@vgvassilev The clang tidy ci now runs with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vgvassilev based on the PR in CppInterOp this should fix the clang tidy issue. Its at least running in CppInterOp again after these changes. It seems the one action now has issues taking multiple commands.