Add check-clad-execonly target
#875
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #875 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 53 53
Lines 7805 7805
=======================================
Hits 7344 7344
Misses 461 461 |
There was a problem hiding this comment.
That's quite handy. Thank you! I bet @PetroZarytskyi will appreciate that maybe more than anybody else ;)
test/CMakeLists.txt
Outdated
| @@ -24,6 +24,8 @@ if(CLAD_BUILT_STANDALONE) | |||
| set(LLVM_LIBS_DIR ${LLVM_INSTALL_PREFIX}/lib/) | |||
| endif() | |||
|
|
|||
| set(CLAD_FILECHECK_CHECK_EXEC_ONLY False) | |||
There was a problem hiding this comment.
Why do we need a separate option here? Can't we just dial the target with make check-clad-exec-only?
There was a problem hiding this comment.
This option is used for configuring lit.cfg for the two cases -- check derivative code and don't check derivative code. Now we have two lit.site.cfg files that represents these two cases: test/lit.site.cfg and test/CheckExecOnly/lit.site.cfg.
This option is used so that we set the correct value of config.filecheck_check_exec_only when we call configure_lit_site_cfg.
test/CMakeLists.txt
Outdated
| set(CLAD_FILECHECK_CHECK_EXEC_ONLY True) | ||
| configure_lit_site_cfg( | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in | ||
| ${CMAKE_CURRENT_BINARY_DIR}/CheckExecOnly/lit.site.cfg |
There was a problem hiding this comment.
Can we get away without creating a new folder? I suspect that you could pass an extra configuration to lit. Using lit --debug might be able to hint you how to do it...
There was a problem hiding this comment.
This seems interesting. I will look into it.
There was a problem hiding this comment.
@parth-07, I've pushed some changes which make the implementation a bit more flexible. Can you take a look?
test/CMakeLists.txt
Outdated
| @@ -74,6 +82,14 @@ add_lit_testsuite(check-clad "Running the Clad regression tests" | |||
| ) | |||
| set_target_properties(check-clad PROPERTIES FOLDER "Clad tests") | |||
|
|
|||
| add_lit_testsuite(check-clad-exec-only "Running the Clad regression tests" | |||
There was a problem hiding this comment.
| add_lit_testsuite(check-clad-exec-only "Running the Clad regression tests" | |
| add_lit_testsuite(check-clad-exec-only "Running the Clad execution regression tests" |
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
changed the title
check-clad-exec-only targetcheck-clad-execonly target
This commit adds a new verification target, 'check-clad-exec-only'. This target only verifies the 'CHECK-EXEC' filecheck checks. It is helpful during the development phase when derivative code is expected to change frequently. Co-authored-by: Vassil Vassilev <[email protected]> Fixes vgvassilev#874
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Looks good to me. @vgvassilev Thank you for the changes. Your changes made the functionality much more flexible and clean.
This commit adds a new verification target, 'check-clad-execonly'. This target only verifies the 'CHECK-EXEC' filecheck checks. It is helpful during the development phase when derivative code is expected to change frequently.
Fixes #874