Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-repl tests to make sure we do not break repls. #872

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

vgvassilev
Copy link
Owner

@vgvassilev vgvassilev commented Apr 26, 2024

Fixes #854, fixes #867.

@vgvassilev vgvassilev force-pushed the add-clang-repl-test branch from 92fc173 to 77ed5b4 Compare April 26, 2024 13:41
@vgvassilev vgvassilev requested a review from parth-07 April 26, 2024 13:41
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.81%. Comparing base (d879f1b) to head (509e151).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          51       51           
  Lines        7618     7620    +2     
=======================================
+ Hits         7223     7225    +2     
  Misses        395      395           
Files Coverage Δ
tools/ClangPlugin.cpp 95.66% <100.00%> (+0.02%) ⬆️
tools/ClangPlugin.h 94.02% <100.00%> (ø)
Files Coverage Δ
tools/ClangPlugin.cpp 95.66% <100.00%> (+0.02%) ⬆️
tools/ClangPlugin.h 94.02% <100.00%> (ø)

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev requested a review from vaithak April 26, 2024 17:13
@vgvassilev vgvassilev force-pushed the add-clang-repl-test branch from 77ed5b4 to 9ff24d9 Compare April 26, 2024 17:55
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev force-pushed the add-clang-repl-test branch from 9ff24d9 to eaead8b Compare April 26, 2024 18:08
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev force-pushed the add-clang-repl-test branch from eaead8b to 2f0ca61 Compare April 26, 2024 18:35
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev force-pushed the add-clang-repl-test branch from 2f0ca61 to 989395d Compare April 26, 2024 19:10
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev force-pushed the add-clang-repl-test branch from 989395d to 509e151 Compare April 27, 2024 07:24
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev merged commit 922bd1c into master Apr 28, 2024
89 checks passed
@vgvassilev vgvassilev deleted the add-clang-repl-test branch April 28, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the assert on AppendDelayed Add tests for clang-repl
3 participants