Make const loop variables global and drop const. #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 48 48
Lines 7061 7062 +1
=======================================
+ Hits 6664 6665 +1
Misses 397 397
|
PetroZarytskyi
force-pushed
the
const-loop-vars
branch
from
87d1c89 to
f26c560
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
We didn't take into account const variables inside loops can be re-initialized on different loop iterations so we have to store them just like non-const variables. const should be dropped to allow us to replace initializations with assignments. Fixes vgvassilev#667.
PetroZarytskyi
force-pushed
the
const-loop-vars
branch
from
f26c560 to
d057047
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, local variables in loops are moved to function globals (the initialization is replaced with an assignment in the same place). This is done for the variable's value to not get overwritten on the next loop iteration. However, this is currently not done for const variables since we didn't account for the fact they can be re-initialized with different values on different loop iterations. Therefore, we have to do the same process for const local variables but drop constness (they need to be reassigned every loop iteration).
Fixes #667.