Add LLVM17 support. #675
Merged
Add LLVM17 support. #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 94.37% 94.39% +0.01%
==========================================
Files 48 48
Lines 7062 7087 +25
==========================================
+ Hits 6665 6690 +25
Misses 397 397
|
vgvassilev
force-pushed
the
add-clang-17
branch
from
936dcd2 to
8be26fd
Compare
vgvassilev
commented
Dec 27, 2023
test/FirstDerivative/Loops.C
Outdated
| @@ -378,7 +378,7 @@ double fn10_darg0(double x, size_t n); | |||
| // CHECK-NEXT: { | |||
| // CHECK-NEXT: size_t _d_count = 0; | |||
| // CHECK-NEXT: size_t _d_max_count = _d_n; | |||
| // CHECK-NEXT: for (size_t count = 0; max_count; ++count) { | |||
| // CHECK-NEXT: for (size_t count = 0; size_t max_count = n; ++count) { | |||
There was a problem hiding this comment.
@PetroZarytskyi, can you take a look at this change - I believe it was broken before that patch...
There was a problem hiding this comment.
@vgvassilev Yes. I think this was a bug in clang with dumping for-loop condition inits. It had to do with the fact that technically in such cases the condition is max_count and size_t max_count = n is the condition init.
There was a problem hiding this comment.
Ok, I've fixed it by making it conditional in the test...
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vgvassilev
force-pushed
the
add-clang-17
branch
from
8be26fd to
25e2f3f
Compare
This patch replaces the artificial handling of the scopes and accesses the private CurScope member of Sema. This allows us to build precise lexical scope setup for when building AST nodes. That's essential for lambda support in clang17 because it tightly couples both Scopes and DeclContexts. The change in test/FirstDerivative/Loops.C is because the pretty printer did not print correctly the variables defined in the condition of the loop until clang17. Fixes #669
vgvassilev
force-pushed
the
add-clang-17
branch
from
25e2f3f to
7faee43
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #669