Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for 'm_' prefix in member vars #656

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

vaithak
Copy link
Collaborator

@vaithak vaithak commented Nov 22, 2023

No description provided.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #656 (26c94f0) into master (d99d4ab) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files          43       43           
  Lines        6334     6334           
=======================================
  Hits         5965     5965           
  Misses        369      369           

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/clad/Differentiator/VectorForwardModeVisitor.h Outdated Show resolved Hide resolved
include/clad/Differentiator/VectorForwardModeVisitor.h Outdated Show resolved Hide resolved
@vaithak vaithak changed the title WIP: Add check for 'm_' prefix in class members Add check for 'm_' prefix in class members Nov 22, 2023
@vaithak vaithak changed the title Add check for 'm_' prefix in class members Add check for 'm_' prefix in member vars Nov 22, 2023
@vgvassilev vgvassilev merged commit e138f8a into vgvassilev:master Nov 22, 2023
73 of 75 checks passed
@vaithak vaithak deleted the tidy-member branch March 13, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants