New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce type cloning. #651

Merged

vgvassilev merged 2 commits into vgvassilev:master from PetroZarytskyi:type-copy

Nov 3, 2023

Collaborator

PetroZarytskyi commented Nov 2, 2023

Currently, the differentiated function takes Type of Expr and Decl from the original function. This is a problem for VariableArrayType since it has a pointer to its size expression (e.g. the type of int arr [k] has a DeclRefExpr of k, which has to be cloned). This pull request introduces type cloning to clone size expressions for VariableArrayType.

codecov bot commented Nov 2, 2023 •

edited

Loading

Codecov Report

Merging #651 (c77113a) into master (cf4ee10) will increase coverage by 0.03%.
The diff coverage is 65.82%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   94.13%   94.17%   +0.03%     
==========================================
  Files          43       43              
  Lines        6312     6334      +22     
==========================================
+ Hits         5942     5965      +23     
+ Misses        370      369       -1

Files	Coverage Δ
include/clad/Differentiator/StmtClone.h	`77.77% <ø> (ø)`
include/clad/Differentiator/VisitorBase.h	`100.00% <ø> (ø)`
lib/Differentiator/ReverseModeVisitor.cpp	`95.90% <100.00%> (ø)`
lib/Differentiator/VisitorBase.cpp	`97.78% <100.00%> (+0.02%)`	⬆️
lib/Differentiator/StmtClone.cpp	`55.23% <62.50%> (+3.87%)`	⬆️

Files	Coverage Δ
include/clad/Differentiator/StmtClone.h	`77.77% <ø> (ø)`
include/clad/Differentiator/VisitorBase.h	`100.00% <ø> (ø)`
lib/Differentiator/ReverseModeVisitor.cpp	`95.90% <100.00%> (ø)`
lib/Differentiator/VisitorBase.cpp	`97.78% <100.00%> (+0.02%)`	⬆️
lib/Differentiator/StmtClone.cpp	`55.23% <62.50%> (+3.87%)`	⬆️

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 22. Check the log or trigger a new build to see more.

include/clad/Differentiator/StmtClone.h Outdated Show resolved Hide resolved

include/clad/Differentiator/VisitorBase.h Outdated Show resolved Hide resolved

lib/Differentiator/StmtClone.cpp Outdated

-              DEFINE_CLONE_EXPR(ImaginaryLiteral, (Clone(Node->getSubExpr()), Node->getType()))
+              DEFINE_CREATE_EXPR(IntegerLiteral, (Ctx, Node->getValue(), CloneType(Node->getType()), Node->getLocation()))
+              DEFINE_CLONE_EXPR_CO(PredefinedExpr, (CLAD_COMPAT_CLANG8_Ctx_ExtraParams Node->getLocation(), CloneType(Node->getType()), Node->getIdentKind() CLAD_COMPAT_CLANG17_IsTransparent(Node), Node->getFunctionName()))
+              DEFINE_CLONE_EXPR(CharacterLiteral, (Node->getValue(), Node->getKind(), CloneType(Node->getType()), Node->getLocation()))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(CharacterLiteral, (Node->getValue(), Node->getKind(), CloneType(Node->getType()), Node->getLocation()))
          
            DEFINE_CLONE_EXPR(auto, (Node->getValue(), Node->getKind(), CloneType(Node->getType()), Node->getLocation()))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp Outdated

    
              DEFINE_CREATE_EXPR(IntegerLiteral, (Ctx, Node->getValue(), CloneType(Node->getType()), Node->getLocation()))

              DEFINE_CLONE_EXPR_CO(PredefinedExpr, (CLAD_COMPAT_CLANG8_Ctx_ExtraParams Node->getLocation(), CloneType(Node->getType()), Node->getIdentKind() CLAD_COMPAT_CLANG17_IsTransparent(Node), Node->getFunctionName()))

              DEFINE_CLONE_EXPR(CharacterLiteral, (Node->getValue(), Node->getKind(), CloneType(Node->getType()), Node->getLocation()))

              DEFINE_CLONE_EXPR(ImaginaryLiteral, (Clone(Node->getSubExpr()), CloneType(Node->getType())))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(ImaginaryLiteral, (Clone(Node->getSubExpr()), CloneType(Node->getType())))
          
            DEFINE_CLONE_EXPR(auto, (Clone(Node->getSubExpr()), CloneType(Node->getType())))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp Outdated

               DEFINE_CLONE_EXPR(ParenExpr, (Node->getLParen(), Node->getRParen(), Clone(Node->getSubExpr())))
-              DEFINE_CLONE_EXPR(ArraySubscriptExpr, (Clone(Node->getLHS()), Clone(Node->getRHS()), Node->getType(), Node->getValueKind(), Node->getObjectKind(), Node->getRBracketLoc()))
+              DEFINE_CLONE_EXPR(ArraySubscriptExpr, (Clone(Node->getLHS()), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind(), Node->getRBracketLoc()))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(ArraySubscriptExpr, (Clone(Node->getLHS()), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind(), Node->getRBracketLoc()))
          
            DEFINE_CLONE_EXPR(auto, (Clone(Node->getLHS()), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind(), Node->getRBracketLoc()))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp Outdated

-              DEFINE_CREATE_EXPR(CXXConstCastExpr, (Ctx, Node->getType(), Node->getValueKind(), Clone(Node->getSubExpr()), Node->getTypeInfoAsWritten(), Node->getOperatorLoc(), Node->getRParenLoc(), Node->getAngleBrackets()))
-              DEFINE_CREATE_EXPR(CXXConstructExpr, (Ctx, Node->getType(), Node->getLocation(), Node->getConstructor(), Node->isElidable(), clad_compat::makeArrayRef(Node->getArgs(), Node->getNumArgs()), Node->hadMultipleCandidates(), Node->isListInitialization(), Node->isStdInitListInitialization(), Node->requiresZeroInitialization(), Node->getConstructionKind(), Node->getParenOrBraceRange()))
-              DEFINE_CREATE_EXPR(CXXFunctionalCastExpr, (Ctx, Node->getType(), Node->getValueKind(), Node->getTypeInfoAsWritten(), Node->getCastKind(), Clone(Node->getSubExpr()), 0 /*EP*/CLAD_COMPAT_CLANG12_CastExpr_GetFPO(Node), Node->getLParenLoc(), Node->getRParenLoc()))
+              DEFINE_CLONE_EXPR(CompoundLiteralExpr, (Node->getLParenLoc(), Node->getTypeSourceInfo(), CloneType(Node->getType()), Node->getValueKind(), Clone(Node->getInitializer()), Node->isFileScope()))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(CompoundLiteralExpr, (Node->getLParenLoc(), Node->getTypeSourceInfo(), CloneType(Node->getType()), Node->getValueKind(), Clone(Node->getInitializer()), Node->isFileScope()))
          
            DEFINE_CLONE_EXPR(auto, (Node->getLParenLoc(), Node->getTypeSourceInfo(), CloneType(Node->getType()), Node->getValueKind(), Clone(Node->getInitializer()), Node->isFileScope()))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

Owner

vgvassilev Nov 2, 2023

This should probably be ignored.

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

vgvassilev reviewed

View reviewed changes

Owner

vgvassilev left a comment

Can we add a test case and address the clang-tidy issues?

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 12. Check the log or trigger a new build to see more.

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

lib/Differentiator/StmtClone.cpp Outdated

-              DEFINE_CLONE_EXPR(MaterializeTemporaryExpr, (Node->getType(), CLAD_COMPAT_CLANG10_GetTemporaryExpr(Node), Node->isBoundToLvalueReference()))
-              DEFINE_CLONE_EXPR_CO11(CompoundAssignOperator, (CLAD_COMPAT_CLANG11_Ctx_ExtraParams Clone(Node->getLHS()), Clone(Node->getRHS()), Node->getOpcode(), Node->getType(),
+              DEFINE_CLONE_EXPR(MaterializeTemporaryExpr, (CloneType(Node->getType()), CLAD_COMPAT_CLANG10_GetTemporaryExpr(Node), Node->isBoundToLvalueReference()))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(MaterializeTemporaryExpr, (CloneType(Node->getType()), CLAD_COMPAT_CLANG10_GetTemporaryExpr(Node), Node->isBoundToLvalueReference()))
          
            DEFINE_CLONE_EXPR(auto, (CloneType(Node->getType()), CLAD_COMPAT_CLANG10_GetTemporaryExpr(Node), Node->isBoundToLvalueReference()))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp Outdated

-              DEFINE_CLONE_EXPR(GNUNullExpr, (Node->getType(), Node->getTokenLocation()))
-              DEFINE_CLONE_EXPR(VAArgExpr, (Node->getBuiltinLoc(), Clone(Node->getSubExpr()), Node->getWrittenTypeInfo(), Node->getRParenLoc(), Node->getType(), Node->isMicrosoftABI()))
-              DEFINE_CLONE_EXPR(ImplicitValueInitExpr, (Node->getType()))
+              DEFINE_CLONE_EXPR(ConditionalOperator, (Clone(Node->getCond()), Node->getQuestionLoc(), Clone(Node->getLHS()), Node->getColonLoc(), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind()))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(ConditionalOperator, (Clone(Node->getCond()), Node->getQuestionLoc(), Clone(Node->getLHS()), Node->getColonLoc(), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind()))
          
            DEFINE_CLONE_EXPR(auto, (Clone(Node->getCond()), Node->getQuestionLoc(), Clone(Node->getLHS()), Node->getColonLoc(), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind()))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp Outdated

-              DEFINE_CLONE_EXPR(VAArgExpr, (Node->getBuiltinLoc(), Clone(Node->getSubExpr()), Node->getWrittenTypeInfo(), Node->getRParenLoc(), Node->getType(), Node->isMicrosoftABI()))
-              DEFINE_CLONE_EXPR(ImplicitValueInitExpr, (Node->getType()))
+              DEFINE_CLONE_EXPR(ConditionalOperator, (Clone(Node->getCond()), Node->getQuestionLoc(), Clone(Node->getLHS()), Node->getColonLoc(), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind()))
+              DEFINE_CLONE_EXPR(AddrLabelExpr, (Node->getAmpAmpLoc(), Node->getLabelLoc(), Node->getLabel(), CloneType(Node->getType())))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(AddrLabelExpr, (Node->getAmpAmpLoc(), Node->getLabelLoc(), Node->getLabel(), CloneType(Node->getType())))
          
            DEFINE_CLONE_EXPR(auto, (Node->getAmpAmpLoc(), Node->getLabelLoc(), Node->getLabel(), CloneType(Node->getType())))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp Outdated

-              DEFINE_CLONE_EXPR(ImplicitValueInitExpr, (Node->getType()))
+              DEFINE_CLONE_EXPR(ConditionalOperator, (Clone(Node->getCond()), Node->getQuestionLoc(), Clone(Node->getLHS()), Node->getColonLoc(), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind()))
+              DEFINE_CLONE_EXPR(AddrLabelExpr, (Node->getAmpAmpLoc(), Node->getLabelLoc(), Node->getLabel(), CloneType(Node->getType())))
+              DEFINE_CLONE_EXPR(StmtExpr, (Clone(Node->getSubStmt()), CloneType(Node->getType()), Node->getLParenLoc(), Node->getRParenLoc() CLAD_COMPAT_CLANG10_StmtExpr_Create_ExtraParams ))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(StmtExpr, (Clone(Node->getSubStmt()), CloneType(Node->getType()), Node->getLParenLoc(), Node->getRParenLoc() CLAD_COMPAT_CLANG10_StmtExpr_Create_ExtraParams ))
          
            DEFINE_CLONE_EXPR(auto, (Clone(Node->getSubStmt()), CloneType(Node->getType()), Node->getLParenLoc(), Node->getRParenLoc() CLAD_COMPAT_CLANG10_StmtExpr_Create_ExtraParams ))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp Outdated

+              DEFINE_CLONE_EXPR(ConditionalOperator, (Clone(Node->getCond()), Node->getQuestionLoc(), Clone(Node->getLHS()), Node->getColonLoc(), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind()))
+              DEFINE_CLONE_EXPR(AddrLabelExpr, (Node->getAmpAmpLoc(), Node->getLabelLoc(), Node->getLabel(), CloneType(Node->getType())))
+              DEFINE_CLONE_EXPR(StmtExpr, (Clone(Node->getSubStmt()), CloneType(Node->getType()), Node->getLParenLoc(), Node->getRParenLoc() CLAD_COMPAT_CLANG10_StmtExpr_Create_ExtraParams ))
+              DEFINE_CLONE_EXPR(ChooseExpr, (Node->getBuiltinLoc(), Clone(Node->getCond()), Clone(Node->getLHS()), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind(), Node->getRParenLoc(), Node->isConditionTrue() CLAD_COMPAT_CLANG11_ChooseExpr_EtraParams_Removed))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(ChooseExpr, (Node->getBuiltinLoc(), Clone(Node->getCond()), Clone(Node->getLHS()), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind(), Node->getRParenLoc(), Node->isConditionTrue() CLAD_COMPAT_CLANG11_ChooseExpr_EtraParams_Removed))
          
            DEFINE_CLONE_EXPR(auto, (Node->getBuiltinLoc(), Clone(Node->getCond()), Clone(Node->getLHS()), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind(), Node->getRParenLoc(), Node->isConditionTrue() CLAD_COMPAT_CLANG11_ChooseExpr_EtraParams_Removed))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp Outdated

+              DEFINE_CLONE_EXPR(AddrLabelExpr, (Node->getAmpAmpLoc(), Node->getLabelLoc(), Node->getLabel(), CloneType(Node->getType())))
+              DEFINE_CLONE_EXPR(StmtExpr, (Clone(Node->getSubStmt()), CloneType(Node->getType()), Node->getLParenLoc(), Node->getRParenLoc() CLAD_COMPAT_CLANG10_StmtExpr_Create_ExtraParams ))
+              DEFINE_CLONE_EXPR(ChooseExpr, (Node->getBuiltinLoc(), Clone(Node->getCond()), Clone(Node->getLHS()), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind(), Node->getRParenLoc(), Node->isConditionTrue() CLAD_COMPAT_CLANG11_ChooseExpr_EtraParams_Removed))
+              DEFINE_CLONE_EXPR(GNUNullExpr, (CloneType(Node->getType()), Node->getTokenLocation()))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(GNUNullExpr, (CloneType(Node->getType()), Node->getTokenLocation()))
          
            DEFINE_CLONE_EXPR(auto, (CloneType(Node->getType()), Node->getTokenLocation()))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp Outdated

+              DEFINE_CLONE_EXPR(StmtExpr, (Clone(Node->getSubStmt()), CloneType(Node->getType()), Node->getLParenLoc(), Node->getRParenLoc() CLAD_COMPAT_CLANG10_StmtExpr_Create_ExtraParams ))
+              DEFINE_CLONE_EXPR(ChooseExpr, (Node->getBuiltinLoc(), Clone(Node->getCond()), Clone(Node->getLHS()), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind(), Node->getRParenLoc(), Node->isConditionTrue() CLAD_COMPAT_CLANG11_ChooseExpr_EtraParams_Removed))
+              DEFINE_CLONE_EXPR(GNUNullExpr, (CloneType(Node->getType()), Node->getTokenLocation()))
+              DEFINE_CLONE_EXPR(VAArgExpr, (Node->getBuiltinLoc(), Clone(Node->getSubExpr()), Node->getWrittenTypeInfo(), Node->getRParenLoc(), CloneType(Node->getType()), Node->isMicrosoftABI()))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(VAArgExpr, (Node->getBuiltinLoc(), Clone(Node->getSubExpr()), Node->getWrittenTypeInfo(), Node->getRParenLoc(), CloneType(Node->getType()), Node->isMicrosoftABI()))
          
            DEFINE_CLONE_EXPR(auto, (Node->getBuiltinLoc(), Clone(Node->getSubExpr()), Node->getWrittenTypeInfo(), Node->getRParenLoc(), CloneType(Node->getType()), Node->isMicrosoftABI()))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

lib/Differentiator/StmtClone.cpp

    
              DEFINE_CLONE_EXPR(ChooseExpr, (Node->getBuiltinLoc(), Clone(Node->getCond()), Clone(Node->getLHS()), Clone(Node->getRHS()), CloneType(Node->getType()), Node->getValueKind(), Node->getObjectKind(), Node->getRParenLoc(), Node->isConditionTrue() CLAD_COMPAT_CLANG11_ChooseExpr_EtraParams_Removed))

              DEFINE_CLONE_EXPR(GNUNullExpr, (CloneType(Node->getType()), Node->getTokenLocation()))

              DEFINE_CLONE_EXPR(VAArgExpr, (Node->getBuiltinLoc(), Clone(Node->getSubExpr()), Node->getWrittenTypeInfo(), Node->getRParenLoc(), CloneType(Node->getType()), Node->isMicrosoftABI()))

              DEFINE_CLONE_EXPR(ImplicitValueInitExpr, (CloneType(Node->getType())))

Contributor

github-actions bot Nov 2, 2023

warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]

Suggested change

      
            DEFINE_CLONE_EXPR(ImplicitValueInitExpr, (CloneType(Node->getType())))
          
            DEFINE_CLONE_EXPR(auto, (CloneType(Node->getType())))

Additional context

lib/Differentiator/StmtClone.cpp:36: expanded from macro 'DEFINE_CLONE_EXPR'

  CLASS* result = new (Ctx) CLASS CTORARGS;             \
  ^

vgvassilev reviewed

View reviewed changes

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

clang-tidy made some suggestions

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

Contributor

github-actions bot commented Nov 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

PetroZarytskyi force-pushed the type-copy branch from 9197070 to 0864e71 Compare

November 3, 2023 07:59

Contributor

github-actions bot commented Nov 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

vgvassilev force-pushed the type-copy branch from 0864e71 to 44ed0e7 Compare

November 3, 2023 08:16

PetroZarytskyi and others added 2 commits

November 3, 2023 08:24


          Introduce type cloning.

a884c8c


          Apply suggestions from clang-tidy and clang-format.

c77113a

vgvassilev force-pushed the type-copy branch from 44ed0e7 to c77113a Compare

November 3, 2023 08:24

Contributor

github-actions bot commented Nov 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

Owner

vgvassilev commented Nov 3, 2023

The coverage and osx timeouts seem unrelated.

vgvassilev merged commit 1bdd261 into vgvassilev:master

74 of 77 checks passed

PetroZarytskyi deleted the type-copy branch

December 11, 2023 21:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet