Floating Point Error Estimation RST added #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Oct 26, 2023
QuillPusher
force-pushed
the
FPErrorEstimationDoc
branch
from
54278b6 to
a50af2d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 94.12% 94.17% +0.04%
==========================================
Files 43 43
Lines 6300 6334 +34
==========================================
+ Hits 5930 5965 +35
+ Misses 370 369 -1 |
parth-07
requested changes
Oct 28, 2023
vgvassilev
reviewed
Oct 29, 2023
|
Thanks @parth-07 and @vgvassilev for the review, requested changes incorporated |
|
@parth-07, can you take a look again? @davidlange6, could you take a look and proofread? |
davidlange6
reviewed
Nov 1, 2023
davidlange6
reviewed
Nov 1, 2023
QuillPusher
force-pushed
the
FPErrorEstimationDoc
branch
from
4b10c27 to
539b4e8
Compare
David's Review changes
- Mentioned Chef-FP in relevant places
- Explained Chef-FP in the beginning, linked to paper
- changed FPEE to full form in all places (except in code elements)
Floating Point Error Estimation Doc ("who is this for" removed)
- Floating Point Error Estimation Info and links consolidated in this article
- Added to Side Navigation (shortened to "FP" due to limited space in side menu
- Removed "Who is this article for"
|
Incorporated David's review changes:
|
parth-07
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floating Point Error Estimation Info and links consolidated in this article
Added link to Side Navigation in Index file (shortened the name to "FP" due to limited space in side menu)