Fix tape push expr for clad array in reverse mode #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -95,7 +95,12 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, | |||
| Expr* exprToPush = E; | |||
| if (auto AT = dyn_cast<ArrayType>(E->getType())) { | |||
| Expr* init = getArraySizeExpr(AT, m_Context, *this); | |||
| exprToPush = BuildOp(BO_Comma, E, init); | |||
| Expr* pushArgs[] = {E, init}; | |||
There was a problem hiding this comment.
warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]
Expr* pushArgs[] = {E, init};
^
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
=======================================
Coverage 94.05% 94.05%
=======================================
Files 43 43
Lines 6237 6241 +4
=======================================
+ Hits 5866 5870 +4
Misses 371 371
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using comma expressions for pushing a clad array onto a tape generated a warning and also resulted in invalid results in some cases.
Fixes #635