Add benchmark for expression templates #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
=======================================
Coverage 94.05% 94.05%
=======================================
Files 43 43
Lines 6237 6237
=======================================
Hits 5866 5866
Misses 371 371 |
vgvassilev
reviewed
Oct 3, 2023
vaithak
force-pushed
the
benchmark-exptemp
branch
from
430293a to
01bf9b1
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vaithak
force-pushed
the
benchmark-exptemp
branch
from
01bf9b1 to
432377d
Compare
|
results of the benchmark from github action: |
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Oct 3, 2023
include/clad/Differentiator/Array.h
Outdated
| return array_expression<T, BinarySub, array<T>>(static_cast<T>(0), *this); | ||
| CUDA_HOST_DEVICE array_expression<T, BinarySub, array<T> const&> | ||
| operator-() const { | ||
| return array_expression<T, BinarySub, array<T> const&>(static_cast<T>(0), |
There was a problem hiding this comment.
Suggested change
| return array_expression<T, BinarySub, array<T> const&>(static_cast<T>(0), | |
| return array_expression<T, BinarySub, const array<T>&>(static_cast<T>(0), |
We spell const in clad this way. Can you update the rest of the occurrences?
There was a problem hiding this comment.
fixed and also added to .clang-format
|
clang-tidy review says "All clean, LGTM! 👍" |
vaithak
force-pushed
the
benchmark-exptemp
branch
from
272bb99 to
0ab1f9a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const&qualifiers while creatingarray_expressionobjects to avoid the copying of arrays.