Initial support for expression templates in array and array_ref class #628
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #628 +/- ##
=======================================
Coverage 94.04% 94.05%
=======================================
Files 43 43
Lines 6230 6236 +6
=======================================
+ Hits 5859 5865 +6
Misses 371 371 |
vaithak
changed the title
vaithak
force-pushed
the
expression-template
branch
from
7da6de8 to
fdf2549
Compare
|
This improves the timing for the weighted sum benchmark by a factor of 3 (from around 650ns to about 200ns), but this can be improved further. For the benchmark of the simple case, this doesn't add any improvement mainly because it consists of a loop of the following form: for (int i = 0; i < dim; i++)
r += p[i];The reason is that this current implementation evaluates I will send a separate PR trying this improvement. |
vaithak
force-pushed
the
expression-template
branch
from
fdf2549 to
51b659f
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
include/clad/Differentiator/Array.h
Outdated
| operator=(const array_expression<L, BinaryOp, R>& arr_exp) { | ||
| assert(arr_exp.size() == m_size); | ||
| for (std::size_t i = 0; i < m_size; i++) | ||
| m_arr[i] = static_cast<T>(arr_exp[i]); |
There was a problem hiding this comment.
Why do we need the static_cast here. Doesn't that signal a potential issue due to type incompatibility?
vaithak
force-pushed
the
expression-template
branch
from
51b659f to
f0f55a5
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
This is to speed up the operations for vector mode by ensuring that temporary array objects are not created when performing arithmetic operations of vectors.
Reference used: https://indico.cern.ch/event/450743/contributions/1116430/attachments/1224060/1790963/out-iCSC2016-L1.pdf