Fix call expr to functor inside a function #626
Merged
+81
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #626 +/- ##
==========================================
+ Coverage 94.03% 94.04% +0.01%
==========================================
Files 43 43
Lines 6218 6230 +12
==========================================
+ Hits 5847 5859 +12
Misses 371 371
|
vaithak
force-pushed
the
functor-fix
branch
from
800bcce to
9286fdc
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
parth-07
reviewed
Sep 18, 2023
| @@ -1412,12 +1413,20 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, | |||
| // statements there later. | |||
| std::size_t insertionPoint = getCurrentBlock(direction::reverse).size(); | |||
|
|
|||
| // `CXXOperatorCallExpr` have the `base` expression as the first argument. | |||
| size_t skipFirstArg = 0; | |||
There was a problem hiding this comment.
Apologies for the late review.
What is the main issue if we do not skip the first arg? I suppose it might be required if we modify the functor's member variables in the call operator.
There was a problem hiding this comment.
The first arg in the operator call is the base expression which is not needed in calling the pullback function, I used the logic of skipping the first arg from this in forward mode: https://github.com/vgvassilev/clad/blob/master/lib/Differentiator/BaseForwardModeVisitor.cpp#L980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #625 for the case when a functor is indirectly differentiated because of a call expression inside a function.