Operator overload in reverse mode #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 94.05% 94.09% +0.04%
==========================================
Files 43 43
Lines 6237 6269 +32
==========================================
+ Hits 5866 5899 +33
+ Misses 371 370 -1
|
PhrygianGates
force-pushed
the
operator_overload_rev
branch
from
b18b297 to
34ef818
Compare
PhrygianGates
force-pushed
the
operator_overload_rev
branch
2 times, most recently
from
54b7176 to
f45e87a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
PhrygianGates
force-pushed
the
operator_overload_rev
branch
2 times, most recently
from
75508b2 to
dd0bb36
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
operator_overload_rev
branch
from
dd0bb36 to
9c5aab1
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
operator_overload_rev
branch
from
9c5aab1 to
514ac7c
Compare
vgvassilev
force-pushed
the
operator_overload_rev
branch
from
514ac7c to
92d306b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1597,8 +1603,11 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, | |||
|
|
|||
| /// Add base derivative expression in the derived call output args list if | |||
| /// `CE` is a call to an instance member function. | |||
| if (auto MCE = dyn_cast<CXXMemberCallExpr>(CE)) { | |||
| if (auto MCE = dyn_cast<CXXMemberCallExpr>(CE)) | |||
There was a problem hiding this comment.
warning: 'auto MCE' can be declared as 'const auto *MCE' [llvm-qualified-auto]
Suggested change
| if (auto MCE = dyn_cast<CXXMemberCallExpr>(CE)) | |
| if (const auto *MCE = dyn_cast<CXXMemberCallExpr>(CE)) |
parth-07
requested changes
Aug 30, 2023
For 1, our tests already cover the case. if (!FD->getReturnType()->isVoidType()) {
assert((pullback && !FD->getReturnType()->isVoidType()) &&
"Call to function returning non-void type with no dfdx() is not "
"supported!");
}For 3, I have added tests for unary op. |
PhrygianGates
force-pushed
the
operator_overload_rev
branch
from
66eb42b to
985097e
Compare
Why does the restriction that you mentioned prevent non-reference return types? Also, why do you think it only affects non-reference return type operator overloads, but not non-reference return type ordinary member functions? |
parth-07
reviewed
Sep 3, 2023
parth-07
force-pushed
the
operator_overload_rev
branch
from
985097e to
578b8fc
Compare
| @@ -1749,7 +1762,8 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, | |||
| // derive the called function. | |||
| DiffRequest pullbackRequest{}; | |||
| pullbackRequest.Function = FD; | |||
| pullbackRequest.BaseFunctionName = FD->getNameAsString(); | |||
| pullbackRequest.BaseFunctionName = | |||
There was a problem hiding this comment.
warning: implicit conversion 'clang::Expr *' -> bool [readability-implicit-bool-conversion]
Suggested change
| pullbackRequest.BaseFunctionName = | |
| pullbackCallArgs, ArgDeclStmts, dfdx() != nullptr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for operator overload in reverse mode