-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Basic Forward Mode Differentiation with Enzyme #496
base: master
Are you sure you want to change the base?
Conversation
There is a problem with code: The generated Enzyme derivative function(ie, |
This commit adds support for differentiation of a function of type: ```cpp double func(double x, double y){ return x*y; } ```
c12aa14
to
0ccb8a4
Compare
@@ -214,8 +213,7 @@ namespace clad { | |||
m_DerivativeInFlight = true; | |||
|
|||
DiffInputVarsInfo DVI = request.DVI; | |||
|
|||
DVI = request.DVI; | |||
m_DVI=DVI; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are saving most of the information of DiffRequest request
as separate members in the visitor classes. @vgvassilev Should we directly save the DiffRequest as a member in the visitor classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can add it as a const reference where we could read it. Makes sense, thanks for the suggestion Parth.
@Nirhar, do you have the bandwidth to continue with this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wont be able to work on this now, I can contribute to this after mid-december
This commit adds support for differentiation of a function of type: