Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ProcessDiffRequest responsibility to DerivativeBuilder #450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parth-07
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #450 (08961d5) into master (6f98627) will decrease coverage by 0.27%.
The diff coverage is 93.96%.

❗ Current head 08961d5 differs from pull request most recent head 33224c8. Consider uploading reports for the commit 33224c8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   92.52%   92.25%   -0.28%     
==========================================
  Files          35       37       +2     
  Lines        5363     5200     -163     
==========================================
- Hits         4962     4797     -165     
- Misses        401      403       +2     
Impacted Files Coverage Δ
include/clad/Differentiator/DerivativeBuilder.h 100.00% <ø> (ø)
include/clad/Differentiator/DerivedFnInfo.h 100.00% <ø> (ø)
include/clad/Differentiator/ForwardModeVisitor.h 100.00% <ø> (ø)
include/clad/Differentiator/ReverseModeVisitor.h 98.68% <ø> (ø)
lib/Differentiator/DerivedFnInfo.cpp 100.00% <ø> (ø)
tools/ClangPlugin.h 69.64% <ø> (-4.05%) ⬇️
tools/ClangPlugin.cpp 90.90% <61.11%> (+0.10%) ⬆️
include/clad/Differentiator/DerivedFnCollector.h 100.00% <100.00%> (ø)
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)
lib/Differentiator/DerivedFnCollector.cpp 100.00% <100.00%> (ø)
... and 16 more
Impacted Files Coverage Δ
include/clad/Differentiator/DerivativeBuilder.h 100.00% <ø> (ø)
include/clad/Differentiator/DerivedFnInfo.h 100.00% <ø> (ø)
include/clad/Differentiator/ForwardModeVisitor.h 100.00% <ø> (ø)
include/clad/Differentiator/ReverseModeVisitor.h 98.68% <ø> (ø)
lib/Differentiator/DerivedFnInfo.cpp 100.00% <ø> (ø)
tools/ClangPlugin.h 69.64% <ø> (-4.05%) ⬇️
tools/ClangPlugin.cpp 90.90% <61.11%> (+0.10%) ⬆️
include/clad/Differentiator/DerivedFnCollector.h 100.00% <100.00%> (ø)
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)
lib/Differentiator/DerivedFnCollector.cpp 100.00% <100.00%> (ø)
... and 16 more

@vgvassilev
Copy link
Owner

@parth-07, can you rebase this PR?

@parth-07
Copy link
Collaborator Author

@vgvassilev I have rebased the PR.

@vgvassilev
Copy link
Owner

Can you add more details in the commit message and rebase the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants