[travis] Run clad with clang which has asserts enabled. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
force-pushed
the
enable-rel-with-asserts-osx
branch
4 times, most recently
from
4286ebc to
8f097d1
Compare
vgvassilev
force-pushed
the
enable-rel-with-asserts-osx
branch
3 times, most recently
from
83d3b03 to
27b5efd
Compare
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 82.67% 83.88% +1.21%
==========================================
Files 13 13
Lines 2615 2644 +29
==========================================
+ Hits 2162 2218 +56
+ Misses 453 426 -27
|
vgvassilev
force-pushed
the
enable-rel-with-asserts-osx
branch
from
22ff5bf to
f0fe389
Compare
This gives us a great deal of coverage. Clang has well-developed assert system which often can detect malformed AST. This is very essential for clad as until today I would need to run that by hand, locally on every pull request. At the moment we rely on the fact that llvmlab has such clang builds but unfortunately only for OSX.
vgvassilev
force-pushed
the
enable-rel-with-asserts-osx
branch
4 times, most recently
from
de1b0c1 to
3e90e80
Compare
vgvassilev
force-pushed
the
enable-rel-with-asserts-osx
branch
from
3e90e80 to
47a44ef
Compare
vgvassilev
force-pushed
the
master
branch
8 times, most recently
from
4da9693 to
a5ebb8c
Compare
|
Resolved by #662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us a great deal of coverage. Clang has well-developed assert system
which often can detect malformed AST. This is very essential for clad as until
today I would need to run that by hand, locally on every pull request.