Use ASTContext's printing policy, reuse the Sema variable. NFC #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -170,7 +170,7 @@ struct DiffRequest { | |||
| const clang::FunctionDecl* m_TopMostFD = nullptr; | |||
| clang::Sema& m_Sema; | |||
|
|
|||
| RequestOptions& m_Options; | |||
| const RequestOptions& m_Options; | |||
There was a problem hiding this comment.
warning: member 'm_Options' of type 'const RequestOptions &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]
const RequestOptions& m_Options;
^| clang::PrintingPolicy Policy(LangOpts); | ||
| Policy.Bool = true; | ||
| ASTContext &C = S.getASTContext(); | ||
| clang::PrintingPolicy Policy = C.getPrintingPolicy(); |
There was a problem hiding this comment.
warning: no header providing "clang::PrintingPolicy" is directly included [misc-include-cleaner]
tools/ClangPlugin.cpp:32:
+ #include <clang/AST/PrettyPrinter.h>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
- Coverage 94.56% 94.56% -0.01%
==========================================
Files 51 51
Lines 8963 8960 -3
==========================================
- Hits 8476 8473 -3
Misses 487 487
|
vgvassilev
force-pushed
the
fix-printing-policy
branch
from
bfe804b to
7dec3a9
Compare
vgvassilev
force-pushed
the
fix-printing-policy
branch
from
7dec3a9 to
0e5b0b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.