fix cmake dependencies when building together with clang #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1168 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 51 51
Lines 8947 8947
=======================================
Hits 8461 8461
Misses 486 486 |
|
@vgvassilev Compilation succeeded in both cases standalone and along with LLVM. In my local computer. |
vgvassilev
approved these changes
Dec 13, 2024
vgvassilev
added a commit
that referenced
this pull request
Dec 13, 2024
…)" This reverts commit c1a87d4.
vgvassilev
added a commit
that referenced
this pull request
Dec 15, 2024
…)" This reverts commit c1a87d4.
vgvassilev
added a commit
that referenced
this pull request
Dec 15, 2024
…)" This reverts commit c1a87d4.
|
@Vipul-Cariappa, looks like this did not solve our problem, can you revert it since I think this moves the dependencies in a unexpected place? |
Vipul-Cariappa
added a commit
to Vipul-Cariappa/clad
that referenced
this pull request
Dec 16, 2024
…assilev#1168)" This reverts commit c1a87d4.
|
@vgvassilev, opened PR at #1173 reverting this. |
vgvassilev
pushed a commit
that referenced
this pull request
Dec 16, 2024
…)" This reverts commit c1a87d4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By any chance is this a better way to describe dependencies?
I am building it locally. Will update you if/when it succeeds.