Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to handle recursive calls separately in the reverse mode #1160

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

PetroZarytskyi
Copy link
Collaborator

Currently, we declare pullbacks before generating the body. This means that when f is differentiated, f_pullback has already been declared. Therefore, HandleNestedDiffRequest is capable of finding it.

@PetroZarytskyi PetroZarytskyi marked this pull request as ready for review December 3, 2024 15:59
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (48b76c4) to head (bca7dee).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1160      +/-   ##
==========================================
- Coverage   94.56%   94.55%   -0.01%     
==========================================
  Files          51       51              
  Lines        8944     8933      -11     
==========================================
- Hits         8458     8447      -11     
  Misses        486      486              
Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 95.58% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 95.58% <100.00%> (-0.02%) ⬇️

@PetroZarytskyi
Copy link
Collaborator Author

The diff looks like the code was rewritten, although, it just removed the block after if (FD == m_DiffReq.Function &&... and left the else-block as it was. The diff is confusing because of the indentation.

Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev
Copy link
Owner

clang-tidy seem to be broken again...

@vgvassilev vgvassilev merged commit 6228385 into vgvassilev:master Dec 3, 2024
89 of 90 checks passed
@PetroZarytskyi PetroZarytskyi deleted the recursive branch December 4, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants