Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone printf and fprintf calls #1147

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

kchristin22
Copy link
Collaborator

Closes #1146

@kchristin22 kchristin22 self-assigned this Nov 20, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.56%. Comparing base (8d916fe) to head (1ef0d23).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
lib/Differentiator/ReverseModeVisitor.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
+ Coverage   94.43%   94.56%   +0.13%     
==========================================
  Files          51       51              
  Lines        8928     8941      +13     
==========================================
+ Hits         8431     8455      +24     
+ Misses        497      486      -11     
Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 95.60% <0.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 95.60% <0.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@kchristin22
Copy link
Collaborator Author

This PR will be revisited when #1150 is fixed.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit b5e0d12 into vgvassilev:master Nov 22, 2024
89 of 90 checks passed
kchristin22 added a commit to kchristin22/clad that referenced this pull request Nov 22, 2024
* Clone printf and fprintf calls

* Add FIXME and print loop index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the use of printf statements in the original function
2 participants