Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix struct initialization and return stmts #1142

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

kchristin22
Copy link
Collaborator

No description provided.

@kchristin22 kchristin22 self-assigned this Nov 17, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (fe11e45) to head (6ead8c2).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
+ Coverage   94.43%   94.56%   +0.12%     
==========================================
  Files          51       51              
  Lines        8928     8939      +11     
==========================================
+ Hits         8431     8453      +22     
+ Misses        497      486      -11     
Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeForwPassVisitor.cpp 98.78% <100.00%> (+0.02%) ⬆️
lib/Differentiator/ReverseModeVisitor.cpp 95.59% <100.00%> (+0.04%) ⬆️
lib/Differentiator/StmtClone.cpp 68.44% <100.00%> (+4.07%) ⬆️
Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeForwPassVisitor.cpp 98.78% <100.00%> (+0.02%) ⬆️
lib/Differentiator/ReverseModeVisitor.cpp 95.59% <100.00%> (+0.04%) ⬆️
lib/Differentiator/StmtClone.cpp 68.44% <100.00%> (+4.07%) ⬆️
---- 🚨 Try these New Features:

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

lib/Differentiator/ReverseModeVisitor.cpp Outdated Show resolved Hide resolved
@kchristin22 kchristin22 changed the title Fix rvalue reference's name in pullbacks Fix struct initialization and return stmts Nov 21, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat! LGTM!

@vgvassilev vgvassilev merged commit 284c33e into vgvassilev:master Nov 22, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants