Add cudaMemset call after cudaMalloc for derivative pointers #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1766,6 +1766,22 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, | |||
| .ActOnCallExpr(getCurrentScope(), Clone(CE->getCallee()), Loc, | |||
| llvm::MutableArrayRef<Expr*>(DerivedCallArgs), Loc) | |||
| .get(); | |||
| if (FD->getNameAsString() == "cudaMalloc") { | |||
| if (auto addrOp = dyn_cast<UnaryOperator>(DerivedCallArgs[0])) { | |||
There was a problem hiding this comment.
warning: 'auto addrOp' can be declared as 'auto *addrOp' [llvm-qualified-auto]
Suggested change
| if (auto addrOp = dyn_cast<UnaryOperator>(DerivedCallArgs[0])) { | |
| if (auto *addrOp = dyn_cast<UnaryOperator>(DerivedCallArgs[0])) { |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1129 +/- ##
=======================================
Coverage 94.44% 94.45%
=======================================
Files 50 50
Lines 8770 8781 +11
=======================================
+ Hits 8283 8294 +11
Misses 487 487
|
|
clang-tidy review says "All clean, LGTM! 👍" |
kchristin22
added a commit
to kchristin22/clad
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.