Add support of cuda kernels as pullback functions #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
+ Coverage 94.39% 94.42% +0.02%
==========================================
Files 50 50
Lines 8713 8729 +16
==========================================
+ Hits 8225 8242 +17
+ Misses 488 487 -1
... and 2 files with indirect coverage changes
|
vgvassilev
force-pushed
the
cuda-pullback-host-functions
branch
from
22399c4 to
ed7194c
Compare
parth-07
requested changes
Oct 16, 2024
kchristin22
force-pushed
the
cuda-pullback-host-functions
branch
2 times, most recently
from
96ad6a1 to
e5fa81d
Compare
parth-07
requested changes
Oct 20, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
parth-07
requested changes
Oct 21, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
kchristin22
force-pushed
the
cuda-pullback-host-functions
branch
from
51ae88f to
7ec28c7
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
…y_pullback to mimic its blocking behavior
vgvassilev
force-pushed
the
cuda-pullback-host-functions
branch
from
7ec28c7 to
6a3f79a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1940,7 +1952,8 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, | |||
| OverloadedDerivedFn = | |||
| m_Builder.BuildCallToCustomDerivativeOrNumericalDiff( | |||
| customPushforward, pushforwardCallArgs, getCurrentScope(), | |||
| const_cast<DeclContext*>(FD->getDeclContext())); | |||
| const_cast<DeclContext*>(FD->getDeclContext()), true, true, | |||
There was a problem hiding this comment.
warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
const_cast<DeclContext*>(FD->getDeclContext()), true, true,
^
vgvassilev
reviewed
Oct 28, 2024
kchristin22
force-pushed
the
cuda-pullback-host-functions
branch
from
4959e67 to
5f8b54b
Compare
| @@ -1940,7 +1952,9 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, | |||
| OverloadedDerivedFn = | |||
| m_Builder.BuildCallToCustomDerivativeOrNumericalDiff( | |||
| customPushforward, pushforwardCallArgs, getCurrentScope(), | |||
| const_cast<DeclContext*>(FD->getDeclContext())); | |||
| const_cast<DeclContext*>(FD->getDeclContext()), | |||
There was a problem hiding this comment.
warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
const_cast<DeclContext*>(FD->getDeclContext()),
^| @@ -2041,7 +2055,9 @@ | |||
| OverloadedDerivedFn = | |||
| m_Builder.BuildCallToCustomDerivativeOrNumericalDiff( | |||
| customPullback, pullbackCallArgs, getCurrentScope(), | |||
| const_cast<DeclContext*>(FD->getDeclContext())); | |||
| const_cast<DeclContext*>(FD->getDeclContext()), | |||
There was a problem hiding this comment.
warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
const_cast<DeclContext*>(FD->getDeclContext()),
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.