Fix appendage of nullptrs to args of a CUDA kernel #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1102 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 55 55
Lines 8445 8445
=======================================
Hits 7961 7961
Misses 484 484
|
|
clang-tidy review says "All clean, LGTM! 👍" |
kchristin22
added a commit
to kchristin22/clad
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were appending
nullptrto the rest of the args, whose addresses are accessed whencudaLaunchKernelwas used, butnullptrcannot be referenced. This PR fixes that by pushing back the address of a param initialized tonullptras many times needed.This PR will include changes to the tests of #1092 once merged, to show that the problem is solved before it's ready for merging.