Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for basic Kokkos operations in the rvs mode #1068

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add support for basic Kokkos operations in the rvs mode #1068

merged 1 commit into from
Oct 9, 2024

Conversation

gojakuch
Copy link
Collaborator

No description provided.

@gojakuch gojakuch marked this pull request as draft August 29, 2024 16:49
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.23%. Comparing base (4f2a378) to head (429a229).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1068   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files          48       48           
  Lines        8158     8158           
=======================================
  Hits         7688     7688           
  Misses        470      470

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev
Copy link
Owner

If this is ready to review can you remove the draft status?

@gojakuch
Copy link
Collaborator Author

gojakuch commented Oct 7, 2024 •
edited
Loading

If this is ready to review can you remove the draft status?

not really, I simply rebased it properly yesterday. I'll push some features and tests and mark it as ready for review.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gojakuch gojakuch marked this pull request as ready for review October 8, 2024 21:31
@gojakuch
Copy link
Collaborator Author

gojakuch commented Oct 9, 2024

the failing check just can't find cmake files for some reason or smth like that

@vgvassilev
Copy link
Owner

the failing check just can't find cmake files for some reason or smth like that

Was some network outage issue.

vgvassilev
vgvassilev approved these changes Oct 9, 2024
View reviewed changes
Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit a14a3f6 into vgvassilev:master Oct 9, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gojakuch @vgvassilev