Introduce type cloning.

vgvassilev · Nov 3, 2023 · a884c8c · a884c8c
1 parent cf4ee10
commit a884c8c
Show file tree

Hide file tree

Showing 5 changed files with 228 additions and 89 deletions.
diff --git a/include/clad/Differentiator/StmtClone.h b/include/clad/Differentiator/StmtClone.h
@@ -48,8 +48,12 @@ namespace utils {
     template<class StmtTy>
     StmtTy* Clone(const StmtTy* S);
 
-  // visitor part (not for public use)
-  // Stmt.def could be used if ABSTR_STMT is introduced
+    /// Cloning types is necessary since VariableArrayType
+    /// store a pointer to their size expression.
+    clang::QualType CloneType(const clang::QualType T);
+
+    // visitor part (not for public use)
+    // Stmt.def could be used if ABSTR_STMT is introduced
 #define DECLARE_CLONE_FN(CLASS) clang::Stmt* Visit ## CLASS(clang::CLASS *Node);
     DECLARE_CLONE_FN(BinaryOperator)
     DECLARE_CLONE_FN(UnaryOperator)
@@ -153,6 +157,10 @@ namespace utils {
     ReferencesUpdater(clang::Sema& SemaRef, clang::Scope* S,
                       const clang::FunctionDecl* FD);
     bool VisitDeclRefExpr(clang::DeclRefExpr* DRE);
+    bool VisitStmt(clang::Stmt* S);
+    /// Used to update the size expression of QT
+    /// if QT is VariableArrayType.
+    void updateType(clang::QualType QT);
   };
 } // namespace utils
 } // namespace clad

diff --git a/include/clad/Differentiator/VisitorBase.h b/include/clad/Differentiator/VisitorBase.h
@@ -558,6 +558,9 @@ namespace clad {
     clang::Stmt* Clone(const clang::Stmt* S);
     /// A shorthand to simplify cloning of expressions.
     clang::Expr* Clone(const clang::Expr* E);
+    /// Cloning types is necessary since VariableArrayType
+    /// store a pointer to their size expression.
+    clang::QualType CloneType(const clang::QualType T);
   };
 } // end namespace clad
 

diff --git a/lib/Differentiator/ReverseModeVisitor.cpp b/lib/Differentiator/ReverseModeVisitor.cpp
@@ -2534,11 +2534,11 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
     // Here separate behaviour for record and non-record types is only
     // necessary to preserve the old tests.
     if (VD->getType()->isRecordType())
-      VDClone = BuildVarDecl(VD->getType(), VD->getNameAsString(),
+      VDClone = BuildVarDecl(CloneType(VD->getType()), VD->getNameAsString(),
                              initDiff.getExpr(), VD->isDirectInit(),
                              VD->getTypeSourceInfo(), VD->getInitStyle());
     else
-      VDClone = BuildVarDecl(VD->getType(), VD->getNameAsString(),
+      VDClone = BuildVarDecl(CloneType(VD->getType()), VD->getNameAsString(),
                              initDiff.getExpr(), VD->isDirectInit());
     Expr* derivedVDE = BuildDeclRef(VDDerived);