Always use valid location when generating operators (#1137)

A valid location is required by the debug clang. Partially addresses #428.
vgvassilev · Nov 13, 2024 · 997c8f9 · 997c8f9
1 parent e494c10
commit 997c8f9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/Differentiator/VisitorBase.cpp b/lib/Differentiator/VisitorBase.cpp
@@ -392,13 +392,19 @@ namespace clad {
                              SourceLocation OpLoc) {
     if (!E)
       return nullptr;
+    // Debug clang requires the location to be valid
+    if (!OpLoc.isValid())
+      OpLoc = utils::GetValidSLoc(m_Sema);
     return m_Sema.BuildUnaryOp(nullptr, OpLoc, OpCode, E).get();
   }
 
   Expr* VisitorBase::BuildOp(clang::BinaryOperatorKind OpCode, Expr* L, Expr* R,
                              SourceLocation OpLoc) {
     if (!L || !R)
       return nullptr;
+    // Debug clang requires the location to be valid
+    if (!OpLoc.isValid())
+      OpLoc = utils::GetValidSLoc(m_Sema);
     return m_Sema.BuildBinOp(nullptr, OpLoc, OpCode, L, R).get();
   }
 

diff --git a/test/Arrays/ArrayInputsVectorForwardMode.C b/test/Arrays/ArrayInputsVectorForwardMode.C
@@ -1,8 +1,6 @@
 // RUN: %cladclang %s -I%S/../../include -oArrayInputsVectorForwardMode.out 2>&1 | %filecheck %s
 // RUN: ./ArrayInputsVectorForwardMode.out | %filecheck_exec %s
 
-// XFAIL: asserts
-
 #include "clad/Differentiator/Differentiator.h"
 
 double multiply(const double *arr) {

diff --git a/test/ForwardMode/VectorMode.C b/test/ForwardMode/VectorMode.C
@@ -1,8 +1,6 @@
 // RUN: %cladclang %s -I%S/../../include -oVectorMode.out 2>&1 | %filecheck %s
 // RUN: ./VectorMode.out | %filecheck_exec %s
 
-// XFAIL: asserts
-
 #include "clad/Differentiator/Differentiator.h"
 
 double f1(double x, double y) {

diff --git a/test/ForwardMode/VectorModeInterface.C b/test/ForwardMode/VectorModeInterface.C
@@ -1,7 +1,5 @@
 // RUN: %cladclang %s -I%S/../../include -fsyntax-only -Xclang -verify 2>&1 | %filecheck %s
 
-// XFAIL: asserts
-
 #include "clad/Differentiator/Differentiator.h"
 
 double f1(double x, double y) {