Fix PVD assignment using const_cast

vgvassilev · Nov 17, 2024 · 2eed07b · 2eed07b
1 parent 71582a4
commit 2eed07b
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/lib/Differentiator/ReverseModeVisitor.cpp b/lib/Differentiator/ReverseModeVisitor.cpp
@@ -1894,11 +1894,8 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
       const auto* PVD = FD->getParamDecl(
           i - static_cast<unsigned long>(isMethodOperatorCall));
       if (PVD->getType()->isRValueReferenceType()) {
-        IdentifierInfo* PVDII = PVD->getIdentifier();
         IdentifierInfo* RValueName = CreateUniqueIdentifier("_r");
-        auto* param = CloneParmVarDecl(PVD, PVDII);
-        param->setDeclName(RValueName);
-        PVD = param;
+        const_cast<ParmVarDecl*>(PVD)->setDeclName(RValueName);
       }
       StmtDiff argDiff{};
       // We do not need to create result arg for arguments passed by reference