Add type cloning.

vgvassilev · Sep 12, 2023 · 06c4bed · 06c4bed
1 parent b46f3db
commit 06c4bed
Show file tree

Hide file tree

Showing 3 changed files with 221 additions and 98 deletions.
diff --git a/include/clad/Differentiator/StmtClone.h b/include/clad/Differentiator/StmtClone.h
@@ -48,8 +48,10 @@ namespace utils {
     template<class StmtTy>
     StmtTy* Clone(const StmtTy* S);
 
-  // visitor part (not for public use)
-  // Stmt.def could be used if ABSTR_STMT is introduced
+    clang::QualType CloneType(const clang::QualType T);
+
+    // visitor part (not for public use)
+    // Stmt.def could be used if ABSTR_STMT is introduced
 #define DECLARE_CLONE_FN(CLASS) clang::Stmt* Visit ## CLASS(clang::CLASS *Node);
     DECLARE_CLONE_FN(BinaryOperator)
     DECLARE_CLONE_FN(UnaryOperator)

diff --git a/lib/Differentiator/ReverseModeVisitor.cpp b/lib/Differentiator/ReverseModeVisitor.cpp
@@ -1267,8 +1267,8 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
     for (std::size_t i = 0; i < Indices.size(); i++) {
       /// FIXME: Remove redundant indices vectors.
       StmtDiff IdxDiff = Visit(Indices[i]);
-      clonedIndices[i] = IdxDiff.getExpr();
-      reverseIndices[i] = IdxDiff.getExpr();
+      clonedIndices[i] = Clone(IdxDiff.getExpr());
+      reverseIndices[i] = Clone(IdxDiff.getExpr());
       // reverseIndices[i] = Clone(IdxDiff.getExpr());
       forwSweepDerivativeIndices[i] = IdxDiff.getExpr();
     }
@@ -1988,8 +1988,8 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
       diff = Visit(E, dfdx());
       auto EStored = GlobalStoreAndRef(diff.getExpr());
       if (EStored.getExpr() != diff.getExpr()) {
-        auto* assign = BuildOp(BinaryOperatorKind::BO_Assign, diff.getExpr(),
-                               EStored.getExpr_dx());
+        auto* assign = BuildOp(BinaryOperatorKind::BO_Assign,
+                               Clone(diff.getExpr()), EStored.getExpr_dx());
         if (isInsideLoop)
           addToCurrentBlock(EStored.getExpr(), direction::forward);
         addToCurrentBlock(assign, direction::reverse);
@@ -2002,8 +2002,8 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
       diff = Visit(E, dfdx());
       auto EStored = GlobalStoreAndRef(diff.getExpr());
       if (EStored.getExpr() != diff.getExpr()) {
-        auto* assign = BuildOp(BinaryOperatorKind::BO_Assign, diff.getExpr(),
-                               EStored.getExpr_dx());
+        auto* assign = BuildOp(BinaryOperatorKind::BO_Assign,
+                               Clone(diff.getExpr()), EStored.getExpr_dx());
         if (isInsideLoop)
           addToCurrentBlock(EStored.getExpr(), direction::forward);
         addToCurrentBlock(assign, direction::reverse);