Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/vg/ holidays #35

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Inorien
Copy link

@Inorien Inorien commented Jan 2, 2025

What this does

Makes in-game holiday greetings consistent with those from Holidays.dm and dates.dm

If your upset about any holiday being removed then PR to readd it, this is a /vg/station13 consistency PR

Why it's good

/vg/station13 consistency

How it was tested

Launched without errors

Changelog
🆑

  • tweak: Holidays consistent with /vg/station13 holidays

@Inorien
Copy link
Author

Inorien commented Jan 2, 2025

looks like the linter is shitting itself, some of the removed holidays are referenced elsewhere

@Inorien Inorien marked this pull request as draft January 2, 2025 01:37
@Eneocho Eneocho added the ss13 parity Bringing features from SS13 to SS14. label Jan 2, 2025
@west3436
Copy link
Collaborator

west3436 commented Jan 7, 2025

looks like the linter is shitting itself, some of the removed holidays are referenced elsewhere

Then remove the references, silly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# size/M ss13 parity Bringing features from SS13 to SS14.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants