You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is Logan Reynolds with Remote-Learner, and I've been working with George Chen on the revised fixes to the M27 version of mod_flashcard. George has confirmed the problem appears to be resolved with your latest branch https://github.com/vfremaux/moodle-mod_flashcard/tree/MOODLE_27_STABLE , however I'm submitting this one change to comply with Oracle's concat() function format, just to ensure compatibility across all supported RDBMs. Please feel free to contact if you have any questions, and thank you for your contributions :)
Actually i do not manage any test plan under Oracle. I will by the way
integrate changes and exploit receip in a larger review in my 80
plugins.... ;-)
In case other change trick should appear, i will be glad to handle them
also in a focussed code review to gain efficiency ....
thanks !
Valery
Le 09/05/2016 19:42, logan-reynolds a écrit :
Hello,
This is Logan Reynolds with Remote-Learner, and I've been working with
George Chen on the revised fixes to the M27 version of mod_flashcard.
George has confirmed the problem appears to be resolved with your
latest branch https://github.com/vfremaux/moodle-mod_flashcard/tree/MOODLE_27_STABLE
, however I'm submitting this one change to comply with Oracle's
concat() function format, just to ensure compatibility across all
supported RDBMs. Please feel free to contact if you have any
questions, and thank you for your contributions :)
Regards,
Logan Reynolds
You can view, comment on, or merge this pull request online at:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is Logan Reynolds with Remote-Learner, and I've been working with George Chen on the revised fixes to the M27 version of mod_flashcard. George has confirmed the problem appears to be resolved with your latest branch https://github.com/vfremaux/moodle-mod_flashcard/tree/MOODLE_27_STABLE , however I'm submitting this one change to comply with Oracle's concat() function format, just to ensure compatibility across all supported RDBMs. Please feel free to contact if you have any questions, and thank you for your contributions :)
Regards,
Logan Reynolds