Override equal?
for time based ranges
#16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
First off - thanks for this project, it has been invaluable in our application and we really appreciate the work you have put into this. We recently ran into a small issue caused by the default (provided by Ecto.Type) implementation of
TsRange.equal?
. The default implementation simple checks for strict equality (==
) which is not recommended for for Date/DateTime structs (per the elixir docsRemember, comparisons in Elixir using == and friends are structural and based on the DateTime struct fields. For proper comparison between datetimes, use the compare/2 function.
)This PR adds an override for the
equal?
function for TsRange, TstzRange and DateRange. Let me know if you would like to see any changes to this, or feel free to reject it entirely if you do not find this to be a positive addition to the project