This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
fix: sleep in async executor when there are no futures left to poll #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doinkythederp
suggested changes
Jan 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes this PR makes. Why should it be merged?
The async executor now sleeps when there are no futures left for it to poll.
This stops it from completely starving the OS even when the user has awaited a sleep future.
The
complete_allfunction has also been removed because it was broken and could not easily be fixed.Additional Context
This has been tested in the simulator and on a real V5 Brain.