Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added language setting to allow users to change locale #544

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added language setting to allow users to change locale #544

wants to merge 2 commits into from

Conversation

QuantFox1
Copy link

@QuantFox1 QuantFox1 commented Oct 13, 2022 •
edited
Loading

Added feature as per issue #433

@KforG
Copy link
Collaborator

KforG commented Oct 17, 2022

Nice work.
Look into displaying the language name instead of the language code. Additionally how the language choice can be saved in settings.db. It would be done similarly to how the selected pool is saved I would imagine.

@KforG
Copy link
Collaborator

KforG commented Oct 22, 2022

Does this compile for you? I get a mismatched types error:

backend\settings.go:198:20: undefined: langs.Getlangs
backend\settings.go:213:17: invalid operation: m.GetLang() != lang (mismatched types int and string)
backend\settings.go:214:19: cannot use lang (type string) as type int in argument to m.setIntSetting

@KforG KforG added feature New feature or request help wanted Extra attention is needed labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuantFox1 @KforG