-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Refactor authentication code #2487
Open
Jotschi
wants to merge
16
commits into
vert-x3:master
Choose a base branch
from
Jotschi:dev-auth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the authentication implementation details
Notes from discord meeting:
default void refreshUser(UserContext) {
}
|
Concept for refactoring Exception handling to avoid the use exceptions for common HTTP actions: postAuthentication method:
if (res instance of PostAuthenticationResult) {
PostAuthenticationResult result = postAuthentication(ctx);
} else {
if (res instanceof PostAuthenticationResult.Proceed) {
ctx.next();
}
…
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The refactor enables re-use of authentication implementation details in non vertx-web projects. (e.g. Vert.x gRPC)
There will be a matching PR for
vertx-auth
+vertx-grpc
to incorporate and make use of the refactored codebase.Draft:
This PR introduces two maven modules. These modules have been added as discussed in the discord meeting to limit the diff and make it easier to review the changes since classes eventually have to be moved to
vertx-auth
.Changes:
AuthenticationContext
interfaceAuthenticationHandler
is now generic to accept implementation specific context objectsJWTAuthHandlerImpl
,HTTPAuthorizationHandler
,AuthenticationHandlerImpl
have been refactored to beRoutingContext
agnostic and useAuthenticationContext
instead.UserContextImpl
split intoAbstractUserContext
to enable re-use of codeRoutingContext
now extendsAuthenticationContext
Tasks:
WebHTTPAuthorizationHandler
,WebAuthenticationHandlerImpl
- currently code is duplicatedRoutingContext
->AuthenticationContext
)UserContextImpl
intoUserWebContextImpl
?AuthenticationContext#onContinue
can be added