fixed #85 require an messageId and send message with it #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sammers21
reviewed
Mar 3, 2018
| * @return a reference to this, so the API can be used fluently | ||
| */ | ||
| @Fluent | ||
| MqttEndpoint publishWithId(String topic, Buffer payload, MqttQoS qosLevel, boolean isDup, boolean isRetain,int messageId); |
There was a problem hiding this comment.
How can a message Id generated by hands be useful?
| * require an messageId | ||
| * @return the next messageId | ||
| */ | ||
| int requireMessageId(); |
There was a problem hiding this comment.
What is a purpose of this?
|
I do think that giving the possibility to the user to set the message-id can lead to a lot of problems even considering that I should review the @Sammers21 PR (I know Pavel ... you hate me ;)) about in-flight messages. The message-id is for internal purpose of the protocol I think that PR #86 makes more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #85 require an messageId and send message with it, when get ack from remote client , will kown the message is success. if no ack for a long time , i can try again send the same message with the same messageId .