Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemPropertyVariables configuration option #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

systemPropertyVariables configuration option #8

wants to merge 1 commit into from

Conversation

msiedlarek
Copy link

This patch adds a systemPropertyVariables configuration option, which allows you to define system properties to be set when running a module.

This is particularly useful for setting the org.vertx.logger-delegate-factory-class-name property (my use case).

The option name and concept comes from the Apache Maven Surefire plugin (https://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html).

@purplefox
Copy link
Member

Have you signed the Eclipse CLA? Also, can you provide the email address you signed it with?

@msiedlarek
Copy link
Author

Well, I tried to... https://bugs.eclipse.org/bugs/show_bug.cgi?id=412009 . I'll let you know as soon as it's done.

@purplefox
Copy link
Member

Weird - I have no problem signing it, and lots of other people have without problem.

Can you try a different browser?

@msiedlarek
Copy link
Author

Tried Safari 6.0.5, Chrome 27 and Firefox 21 with same result.

@msiedlarek
Copy link
Author

The CLA bug have been fixed and I've signed mine. You are free to merge my humble patch.

@adamdyga
Copy link

Simple but useful feature, will it be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants