Allow setting init script through cli #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusyong
reviewed
Nov 21, 2024
src/webview.rs
Outdated
| @@ -82,6 +83,11 @@ impl Window { | |||
| w | |||
| ); | |||
| } | |||
| EmbedderMsg::LoadStart => { | |||
| if let Some(init_script) = &self.init_script { | |||
| execute_script_async(&sender, &webview_id, init_script); | |||
There was a problem hiding this comment.
Why doesn't it just use usercript?
There was a problem hiding this comment.
I want to use it later on for the webview controller's APIs, for the CLI usage, we can also add in userscript along side this, since that one needs to take a file instead of a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.