Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #6

Merged
merged 60 commits into from
Mar 6, 2024
Merged

Develop #6

merged 60 commits into from
Mar 6, 2024

Conversation

thoraj
Copy link

@thoraj thoraj commented Mar 6, 2024

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

t3chguy and others added 30 commits February 19, 2024 12:32
* Remove allchange dependency

Signed-off-by: Michael Telatynski <[email protected]>

* Remove stale release scripts

Signed-off-by: Michael Telatynski <[email protected]>

* Update pull request template to remove allchange behaviours

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
* Reuse exported common type

Signed-off-by: Michael Telatynski <[email protected]>

* Improve client metadata used for OIDC dynamic registration

Signed-off-by: Michael Telatynski <[email protected]>

* Fix Native OIDC for Element Desktop by including ssoid in the url_state of the /auth call

Signed-off-by: Michael Telatynski <[email protected]>

* Reuse exported common type

Signed-off-by: Michael Telatynski <[email protected]>

* Improve client metadata used for OIDC dynamic registration

Signed-off-by: Michael Telatynski <[email protected]>

* Fix typo

Signed-off-by: Michael Telatynski <[email protected]>

* Fix test

Signed-off-by: Michael Telatynski <[email protected]>

* Mock PlatformPeg

Signed-off-by: Michael Telatynski <[email protected]>

* Mock platform

Signed-off-by: Michael Telatynski <[email protected]>

* Add comment

Signed-off-by: Michael Telatynski <[email protected]>

* Improve comment

Signed-off-by: Michael Telatynski <[email protected]>

* Update src/BasePlatform.ts

Co-authored-by: Richard van der Hoff <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
* Mock subtle crypto in OIDC test

To unblock upgrade to oidc-client-ts

Signed-off-by: Michael Telatynski <[email protected]>

* Update dependency oidc-client-ts to v3

* delint

Signed-off-by: Michael Telatynski <[email protected]>

* Ensure oidc-client-ts 3.0.1 to drop crypto-js

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Move mailhog fixture to element-web-test.ts

Signed-off-by: Michael Telatynski <[email protected]>

* Remove spurious debug log

Signed-off-by: Michael Telatynski <[email protected]>

* Lazily set up ElementAppPage subfixtures to avoid conflicting on network routing

Signed-off-by: Michael Telatynski <[email protected]>

* Update playwright/e2e/crypto/utils.ts

---------

Signed-off-by: Michael Telatynski <[email protected]>
* Extract Postgres Docker to its own class

Signed-off-by: Michael Telatynski <[email protected]>

* Don't specify docker `--rm` in CI as it makes debugging harder

Signed-off-by: Michael Telatynski <[email protected]>

* Improve docker commands and introspection

Signed-off-by: Michael Telatynski <[email protected]>

* Remove `HOST_DOCKER_INTERNAL` magic in favour of `host.containers.internal`

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

* Always pipe

Signed-off-by: Michael Telatynski <[email protected]>

* Re-add pipe flag to silence pg_isready and podman checks

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
* Fix gradients spacings on the space panel

Make the gradients two separate ones so they can be fixed pixel widths
from the top & bottom rather than percentages of the height.

Tweak the spacings between the user menu & threads panel to match
the figma and from Gaelle's design.

* Update snapshots

* More screenshots
* Revert ed5ef02

* Update failing snapshots

* Update snapshots after develop merge
* Resolve race condition between opening settings & well-known check in OIDC mode

Signed-off-by: Michael Telatynski <[email protected]>

* Add OIDC-aware and OIDC-native tests using MAS

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
…matrix-org#12246)

* WIP Use browser font size instead of hardcoded 16px

* Add font migration to v3

* Remove custom font size input

* Use a dropdown instead of a slider

* Add margin to the font size dropdown

* Fix `UpdateFontSizeDelta` action typo

* Fix `fontScale`in `Call.ts`

* Rename `baseFontSizeV3` to `fontSizeDelta`

* Update playwright test

* Add `default` next to the browser font size

* Remove remaining `TODO`

* Remove falsy `private`

* Improve doc

* Update snapshots after develop merge

* Remove commented import
…org#12267)

* Fix the space panel getting bigger when gaining a scroll bar

Just makes the scrollbar gutter stable and removes 8px of padding
to compensate, so it will make the bar slightly larger, but it will
no longer change size weirdly if you have too many spaces in too short
a window.

* Tweak margins to keep space panel the same size

* Try 1px more

* Try 1px more to the left

* Fix sizes and disable flex when in narrow mode

* Update screenshots

* Another screenshot

* Last screenshot hopefully
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update all non-major dependencies

* Prettier

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <[email protected]>
…ent resulting in the action failing with rust-sdk (matrix-org#12272)

* Fix overwrite login action not stopping client

* remove unneeded fixture for overwrite login test

* Fix playwrite bad import of app sources

* revert uneeded change on fore OnLoggedIn causing side effects

* Add unit test for overwrite login action

* remove un needed ts-ignore
* Fix spurious session corruption error

Move the server versions check to each time we reconnect to the server
rather than the first time,although, as per comment it will still only
trigger the first time, but it will avoid us awaiting and mean we know
we're connected to the server when we try, and get automatic retries.

Fixes element-hq/element-web#26967

* Move test & add regression test

* Write some more tests

* More comments & catch exceptions in server versions check

* Note caching behaviour

* Typo

Co-authored-by: Richard van der Hoff <[email protected]>

* Remove the bit of the comment that might be wrong

---------

Co-authored-by: Richard van der Hoff <[email protected]>
dbkr and others added 29 commits February 26, 2024 17:14
…-staging

[Backport staging] Fix spurious session corruption error
* Add theme data to EC widget url

Signed-off-by: Timo K <[email protected]>

* test theme

Signed-off-by: Timo K <[email protected]>

---------

Signed-off-by: Timo K <[email protected]>
* Hide the archived section

* Only add archived section if necessary

* Update e2e tests
* Revert 3acd648 - Fix timeline position when moving to a room and coming back

* Fix initialEventId
* Fix alignment of user menu avatar

matrix-org#12267 made the avatar
a couple of pixels out of alignment with the space icons. It just needed
to be moved 2px to the right to match the 18px margin of the space icons
(including the padding from the black border).

Also change elements in the user menu to block elements so they don't
generate extra vertical space in the user menu div, which was causing the
hairline to be too far down.

* Update snapshots

* Typo

Co-authored-by: Robin <[email protected]>

* Reference the span by class

* The img wasn't actually necessary here

---------

Co-authored-by: Robin <[email protected]>
…#12291)

The entrypoint script only passed the first argument so if you specified
multiple test files it would only run the first.

This will need the docker image to be rebuilt on each machine you run it
on to take effect.
* PR template: reminder to document your stuff

* add full stops
* Prevent "Element" hardcoded in i18n files

Signed-off-by: Michael Telatynski <[email protected]>

* Update matrix-web-i18n

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
* Fix TAC opening with keyboard

* Use compound tooltip and icon button

* Revert "Fix TAC opening with keyboard"

This reverts commit 5a1e5d0

* Add missing aria-label

* Update tests

* Add tests

* Fix visual regression

* Fix remaining tooltip

* Fix ref typing

* Fix typing
* Feeds event with relation to unknown to the widget

Signed-off-by: Mikhail Aheichyk <[email protected]>

* Smaller changes

Signed-off-by: Mikhail Aheichyk <[email protected]>

---------

Signed-off-by: Mikhail Aheichyk <[email protected]>
Co-authored-by: Mikhail Aheichyk <[email protected]>
* fix automatic DM avatar with functional members

* add tests for functional members

* add snapshot for functional members avatar test

* update snapshot for functional members avatar test

* restore mocks after each functional members avatar test

* refactor DecoratedRoomAvatar-test

---------

Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: R Midhun Suresh <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
If auto-rageshake-on-UISI is enabled, then when we get a UISI we send the sender a to-device message asking them to also rageshake. Unfortunately, the logic to do so has been broken since c30b263.

Also a few other minor cleanups while we're here.
This changes the styles of buttons, other form controls, and tabs in settings to:

1. Improve their usage of semantic colors, so that they adapt correctly to custom themes
2. Make them more visually coherent with the new Compound design system, as we integrate more of it into the app

This is a re-introduction of matrix-org#12241 with the difference that we're now using our branding colors again on form colors, and buttons have become rounded to match the appearance of new Compound buttons.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <[email protected]>
@thoraj thoraj merged commit c4c619d into verji-develop Mar 6, 2024
14 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.