Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync develop with verji-develop #4

Merged
merged 22 commits into from
Mar 4, 2024
Merged

Sync develop with verji-develop #4

merged 22 commits into from
Mar 4, 2024

Conversation

JohnSimonsen
Copy link

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

RiotRobot and others added 22 commits February 2, 2024 15:02
…en manually migrating to rust from labs (matrix-org#12225)

* Fix StorageManager checks for rust migration manual opt-in

* fix restricted imports

* Moved utility to check db internals into js-sdk

* fix typos and test names

* more timeout for migration test

(cherry picked from commit cdfcd37)
…-staging

[Backport staging] Fix the StorageManger detecting a false positive consistency check when manually migrating to rust from labs
* Enable custom themes to theme Compound

* Remove the now redundant username color variables

They are replaced by the Compound theming options (specifically, username colors can be themed by changing the color of Compound's decorative color tokens).
* Use Compound primary colors for most actions

The "accent" color variable is something we should generally not use anymore: it maps to a Compound text token, which makes its semantics inappropriate for icons and backgrounds, and it clashes with the primary colors present on the Compound components we're now bringing into the app. As discussed with design, we would like to phase out its usage on interactive components in favor of the correct icon and background colors from Compound. This is a best-effort attempt at applying new colors to all the major places that we were previously using "accent": mainly, buttons and form controls are affected.

* Update some more colors

* Update test snapshots

* Fix broken screenshot
So that they use Compound semantic colors correctly and appear more similar to the real components now found in Compound.
…#9329)

* remove lowercase (proposal)

Lowercase doesn't make sense here (at least in German). I suggest removing it or creating a new translatable string.

* remove lowercase

Lowercase doesn't make sense here (at least in German). I suggest removing it or creating a new translatable string.

* Update screenshot

---------

Co-authored-by: David Baker <[email protected]>
* Add A-Element-R labels to rageshakes if rust

* fix import

* Add tests for rageshake  collect

* add ts-ignore in test

* refactor rageshake to match sonar Cognitive Complexity
* Use h1 as first heading in dialogs

The dialog should be modal and therefore the only content active
on the screen, so the title of the dialog should be the top level.

Update snapshots & tests appropriately.

* Just customise the letter spacing on dialog titles
@JohnSimonsen JohnSimonsen merged commit 7a7a290 into verji-develop Mar 4, 2024
16 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants